Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing db.operation for CREATE/DROP/ALTER SQL statement #10020

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

bjrara
Copy link
Contributor

@bjrara bjrara commented Dec 7, 2023

This PR fixed #10031.

After the fix

Sample trace

Span #6
    Trace ID       : 657116b404695ceda8a8588db87581c9
    Parent ID      : 
    ID             : 7845374ea3a9d910
    Name           : CREATE dd62840f-1bdb-44f2-9d95-dc796dabe06d.INDEX
    Kind           : Client
    Start time     : 2023-12-07 00:49:56.179481 +0000 UTC
    End time       : 2023-12-07 00:49:56.179686303 +0000 UTC
    Status code    : Unset
    Status message : 
Attributes:
     -> db.name: Str(xxx)
     -> db.operation: Str(CREATE INDEX)
     -> db.statement: Str(CREATE INDEX types_name ON types (name))
     -> db.system: Str(xxx)
     -> db.user: Str(xxx)
     -> thread.id: Int(1)
     -> thread.name: Str(main)

@bjrara bjrara requested a review from a team as a code owner December 7, 2023 03:35
@bjrara bjrara force-pushed the main branch 6 times, most recently from 96d414f to 8f87387 Compare December 8, 2023 02:07
Copy link
Member

@zeitlinger zeitlinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution 😄

@laurit laurit added this to the v2.2.0 milestone Mar 6, 2024
@bjrara
Copy link
Contributor Author

bjrara commented Mar 6, 2024

I rebased and squashed the commits.

@trask trask merged commit df83eaa into open-telemetry:main Mar 12, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing db.operation for CREATE/DROP/ALTER SQL statement
4 participants