Fix using opentelemetry-spring-boot with java8 #10066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanbisutti
approved these changes
Dec 13, 2023
trask
approved these changes
Dec 13, 2023
Comment on lines
+21
to
+24
| // We compile this module for java 8 because it is used as a dependency in spring-boot-autoconfigure. | ||
| // If this module is compiled for java 17 then gradle can figure out based on the metadata that | ||
| // spring-boot-autoconfigure has a dependency that requires 17 and fails the build when it is used | ||
| // in a project that targets an earlier java version. |
There was a problem hiding this comment.
very interesting, gradle being too smart for us...
heyams
pushed a commit
to heyams/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 13, 2023
elbiocaetano
pushed a commit
to elbiocaetano/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9949