add Spring boot distro version #10276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Jan 18, 2024
...ntelemetry/instrumentation/spring/autoconfigure/resources/DistroVersionResourceProvider.java
Outdated
Show resolved
Hide resolved
jeanbisutti
reviewed
Jan 18, 2024
Tests on |
jeanbisutti
reviewed
Jan 18, 2024
| @@ -37,6 +37,11 @@ public ResourceProvider otelResourceProvider( | |||
| return new SpringResourceProvider(otelSpringResourceProperties, otelResourceProperties); | |||
| } | |||
|
|
|||
| @Bean | |||
| public ResourceProvider otelDistroVersionResourceProvider() { | |||
There was a problem hiding this comment.
Could you also add a test for this?
Two issues, two PRs? This could make it easier to track changes. |
zeitlinger
force-pushed
the
spring-boot-distro-version
branch
from
9899855
to
cf2ac06
Compare
done |
has this been resolved by splitting the PR? |
laurit
reviewed
Jan 22, 2024
...emetry/instrumentation/spring/autoconfigure/resources/DistroVersionResourceProviderTest.java
Outdated
Show resolved
Hide resolved
laurit
approved these changes
Jan 22, 2024
trask
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and minor bug fixes:- add @ConditionalOnMissingBean to LoggingMetricExporter -> #10283- add LoggingMetricExporterAutoConfiguration to spring factories -> #10282