Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic addition of the OTel Logback appender by the OTel starter #10306

Conversation

jeanbisutti
Copy link
Member

With this PR the OTel starter automatically adds the OTel Logback appender if the appender is not configured in an XML file

@jeanbisutti jeanbisutti requested a review from a team as a code owner January 22, 2024 21:53
@denodaeus
Copy link

How can I prevent this from "automagically" breaking my app if I choose to not use logback but instead something like log4j2?

I've followed the instructions for adding log4j2 as the log appender, but I continuously get this "magic":

22:05:06.622 [main] ERROR com.my.app.MyApplication - PortfolioManagementServiceApplication failed to start
java.lang.IllegalArgumentException: Cannot instantiate interface org.springframework.context.ApplicationListener : io.opentelemetry.instrumentation.spring.autoconfigure.instrumentation.logging.LogbackAppenderApplicationListener
at org.springframework.boot.SpringApplication.createSpringFactoriesInstances(SpringApplication.java:449) ~[spring-boot-2.7.8.jar:2.7.8]

@trask
Copy link
Member

trask commented Feb 27, 2024

java.lang.IllegalArgumentException: Cannot instantiate interface org.springframework.context.ApplicationListener : io.opentelemetry.instrumentation.spring.autoconfigure.instrumentation.logging.LogbackAppenderApplicationListener

hi @denodaeus! can you open a new issue for this so that it's not lost? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants