Undertow: restore attached context only when it is for different trace #10336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Jan 26, 2024
Yes the servlet instrumentation does something similar, I took the same traceid check from there. I think the reason why it is(was) done might be different. |
steverao
pushed a commit
to steverao/opentelemetry-java-instrumentation
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10323
Undertow tests pass even without restoring the context. I'm not sure whether it is needed at all, perhaps executor instrumentation has improved since this was originally written and can now propagate the context? Just in case it is needed I changed it so that the context that is attached to the request is restored only when the current context and the attached context have different traces.