Remove deprecated spring properties #10454
Conversation
zeitlinger
force-pushed
the
remove-deprecated-spring-properties
branch
3 times, most recently
from
0ad9d1b
to
15a3ba2
Compare
| @@ -37,7 +37,7 @@ dependencies { | |||
| library("org.springframework.boot:spring-boot-starter-web:$springBootVersion") | |||
| library("org.springframework.boot:spring-boot-starter-webflux:$springBootVersion") | |||
|
|
|||
| compileOnly("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure-spi") | |||
| implementation("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure") | |||
There was a problem hiding this comment.
It should not be library("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure"), as the Spring dependencies? cc @laurit who should know
There was a problem hiding this comment.
library means compileOnly + testImplementation. Using compileOnly is important in javaagent modules, which this module is not. It is also used to support the latest dep test where we change the version for library dependencies to latest version. In my opinion here implementation is the correct choice as it is a required dependency for this module.
|
@zeitlinger usually before removing the properties we do a deprecation cycle, was there a decision to skip this for these? In the pr description could you provide the list of removed properties and their replacements. @trask usually list breaking changes in the changelog, having these available here would make it easier for him. |
@trask and @jeanbisutti asked for the "fast track" because right now there are few users, but we want to make a push with the GA release
done 😄 |
|
will merge after the release (and sorry @zeitlinger looks like lots of conflicts from splitting out the bug fix) |
zeitlinger
force-pushed
the
remove-deprecated-spring-properties
branch
from
10e9a67
to
574a7f1
Compare
zeitlinger
force-pushed
the
remove-deprecated-spring-properties
branch
from
574a7f1
to
33a2c41
Compare
I just had to ignore my all changes from the other PR 😄 @trask ready to merge now |
Based on
- #10512- #10408- #10511- #10530Fixes ##10450
Bug fix
otel.propagatorswere not read correctly: https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/10454/files#diff-70b5a0d550786f16703fb5d2338924d7d213793f610bc24a640bd5f8fa64def5R81 -> split off to #10559Breaking changes
All of these changes coverge towards the behavior of SDK auto config:
logging exporter
otel.exporter.logging.metrics.enabled->otel.metrics.exporter=logging(same for traces, metrics)otel.exporter.logging.enabled=true->otel.metrics.exporter=logging,otel.traces.exporter=logging,otel.logs.exporter=loggingOTLP exporter
otel.exporter.otlp.metrics.enabled->otel.metrics.exporter=otlp(same for traces, metrics) (enabled by default)otel.exporter.otlp.enabled->otel.metrics.exporter=otlp,otel.traces.exporter=otlp,otel.logs.exporter=otlpZipkin exporter
otel.exporter.zipkin.enabled->otel.traces.exporter=zipkinPropagation
otel.propagation.type=tracecontext,baggage->otel.propagators=tracecontext,baggageResource
otel.springboot.resource.attributes->otel.resource.attributes