Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UrlInstrumentation. #1059

Merged
merged 3 commits into from
Aug 20, 2020

Conversation

dengliming
Copy link
Member

closes #1045

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep UrlConnectionTest with this one test:

def "trace request with connection failure #scheme"()

It really tests the underlying HttpURLConnection instrumentation (but still makes sense in class named UrlConnectionTest)

…entation

# Conflicts:
#	instrumentation/http-url-connection/src/main/java/io/opentelemetry/instrumentation/auto/httpurlconnection/UrlInstrumentation.java
@anuraaga
Copy link
Contributor

Thanks!

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask trask merged commit 41bf322 into open-telemetry:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove UrlInstrumentation
3 participants