Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log current thread id and name as span attribute #1093

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Log current thread id and name as span attribute #1093

merged 1 commit into from
Aug 27, 2020

Conversation

mateuszrzeszutek
Copy link
Member

Fixes #942

Changes:

  • Bump opentelementry-java versions
  • Fix all compilation issues
  • Add a new SpanProcessor that appends thread attributes to each span

@mateuszrzeszutek
Copy link
Member Author

One question to the reviewers: do you think that this new processor should be enabled/disabled with a configuration flag?

@iNikem
Copy link
Contributor

iNikem commented Aug 25, 2020

Current snapshot of otel-java is broken. Waiting for open-telemetry/opentelemetry-java#1585 and open-telemetry/opentelemetry-java#1579, then I was going to merge #1057

@mateuszrzeszutek
Copy link
Member Author

Current snapshot of otel-java is broken. Waiting for open-telemetry/opentelemetry-java#1585 and open-telemetry/opentelemetry-java#1579, then I was going to merge #1057

OK -- I'll wait for those fixes and rebase once they're merged.

@iNikem
Copy link
Contributor

iNikem commented Aug 26, 2020

@mateuszrzeszutek please rebase

Log current thread id and name as span attribute
dc68094 
* Bump opentelementry-java versions
* Fix all compilation issues
* Add a new `SpanProcessor` that appends thread attributes to each span
@iNikem
Copy link
Contributor

iNikem commented Aug 27, 2020

One question to the reviewers: do you think that this new processor should be enabled/disabled with a configuration flag?

I think there is no need for such configuration. @trask do you care about that?

trask
trask approved these changes Aug 27, 2020
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mateuszrzeszutek!

I agree no configuration is needed for this.

@trask trask merged commit 2203a37 into open-telemetry:master Aug 27, 2020
@mateuszrzeszutek mateuszrzeszutek mentioned this pull request Sep 17, 2020
Closed
6 tasks
@mateuszrzeszutek mateuszrzeszutek deleted the thread-info branch February 5, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@iNikem iNikem iNikem approved these changes

@anuraaga anuraaga Awaiting requested review from anuraaga

@jkwatson jkwatson Awaiting requested review from jkwatson

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log current thread id and name as span attribute
3 participants
@mateuszrzeszutek @iNikem @trask