Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AWS Active Tracing span linking #10930

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

tylerbenson
Copy link
Member

This aligns with the latest spec change:
open-telemetry/semantic-conventions#354

Providing the Lambda span's parent context should continue to be the responsibility of the global propagator.

Related: open-telemetry/opentelemetry-java-contrib#1032

@tylerbenson
Copy link
Member Author

FYI @rapphil

@trask
Copy link
Member

trask commented Mar 25, 2024

cc @wangzlei @srprash

@tylerbenson
Copy link
Member Author

@trask @laurit please remember to do a release of the contrib repo before the next javaagent release. It doesn't look like that has a regular release cadence like the other java repos do.

@trask
Copy link
Member

trask commented Mar 27, 2024

@trask @laurit please remember to do a release of the contrib repo before the next javaagent release. It doesn't look like that has a regular release cadence like the other java repos do.

thanks for the reminder, sometimes we miss releasing from that repo, just released contrib v1.34.0

@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Mar 27, 2024
@trask
Copy link
Member

trask commented Mar 28, 2024

I think if you rebase (and pull in #10969) it should fix the license check

This aligns with the latest spec change:
open-telemetry/semantic-conventions#354

Providing the Lambda span's parent context should continue to be the responsibility of the global propagator.
@tylerbenson
Copy link
Member Author

Any more blockers here?

@trask
Copy link
Member

trask commented Apr 1, 2024

we'll merge it before v2.3.0. would be great to get an approval from someone in the faas sig if possible.

@trask trask merged commit d7e9098 into open-telemetry:main Apr 1, 2024
49 checks passed
@tylerbenson tylerbenson deleted the tyler/xray-lambda branch April 2, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test native This label can be applied to PRs to trigger them to run native tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants