Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud provider in spring starter #11014

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ dependencies {
library("org.springframework.boot:spring-boot-starter-webflux:$springBootVersion")

implementation("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure")
implementation(project(":sdk-autoconfigure-support"))
compileOnly("io.opentelemetry:opentelemetry-extension-trace-propagators")
compileOnly("io.opentelemetry.contrib:opentelemetry-aws-xray-propagator")
compileOnly("io.opentelemetry:opentelemetry-exporter-logging")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,7 @@ dependencies {
api("io.opentelemetry:opentelemetry-exporter-otlp")
api("io.opentelemetry:opentelemetry-sdk")
api(project(":instrumentation-annotations"))

implementation("io.opentelemetry.contrib:opentelemetry-aws-resources")
implementation("io.opentelemetry.contrib:opentelemetry-gcp-resources")
}
2 changes: 1 addition & 1 deletion javaagent-tooling/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ dependencies {
implementation(project(":instrumentation-api"))
implementation(project(":instrumentation-annotations-support"))
implementation(project(":muzzle"))
implementation(project(":sdk-autoconfigure-support"))

implementation("io.opentelemetry:opentelemetry-api")
testImplementation("io.opentelemetry:opentelemetry-api-incubator")
implementation("io.opentelemetry:opentelemetry-sdk")
implementation("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure")
implementation("io.opentelemetry:opentelemetry-extension-kotlin")
implementation("io.opentelemetry:opentelemetry-extension-trace-propagators")
// the incubator's ViewConfigCustomizer is used to support loading yaml-based metric views
Expand Down

This file was deleted.

13 changes: 13 additions & 0 deletions sdk-autoconfigure-support/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
plugins {
id("otel.java-conventions")
id("otel.publish-conventions")
}

group = "io.opentelemetry.instrumentation"

dependencies {
api("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure")

compileOnly("com.google.code.findbugs:annotations")
testCompileOnly("com.google.code.findbugs:annotations")
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@
* SPDX-License-Identifier: Apache-2.0
*/

package io.opentelemetry.javaagent.tooling.config;
package io.opentelemetry.instrumentation.resources;

import com.google.auto.service.AutoService;
import io.opentelemetry.sdk.autoconfigure.spi.AutoConfigurationCustomizer;
import io.opentelemetry.sdk.autoconfigure.spi.AutoConfigurationCustomizerProvider;
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
Expand All @@ -18,7 +17,6 @@
import java.util.Set;
import javax.annotation.Nullable;

@AutoService(AutoConfigurationCustomizerProvider.class)
public class ResourceProviderPropertiesCustomizer implements AutoConfigurationCustomizerProvider {

private static final Map<String, String> DISABLED_BY_DEFAULT_RESOURCE_PROVIDERS = new HashMap<>();
Expand All @@ -38,7 +36,7 @@ public class ResourceProviderPropertiesCustomizer implements AutoConfigurationCu
"io.opentelemetry.contrib.gcp.resource.GCPResourceProvider", "gcp");
// for testing
DISABLED_BY_DEFAULT_RESOURCE_PROVIDERS.put(
"io.opentelemetry.javaagent.tooling.config.ResourceProviderPropertiesCustomizerTest$Provider",
"io.opentelemetry.instrumentation.resources.ResourceProviderPropertiesCustomizerTest$Provider",
"test");
}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
io.opentelemetry.instrumentation.resources.ResourceProviderPropertiesCustomizer
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* SPDX-License-Identifier: Apache-2.0
*/

package io.opentelemetry.javaagent.tooling.config;
package io.opentelemetry.instrumentation.resources;

import static org.assertj.core.api.Assertions.assertThat;

Expand Down Expand Up @@ -58,7 +58,7 @@ private EnabledTestCase(
@TestFactory
Stream<DynamicTest> enabledTestCases() {
String className =
"io.opentelemetry.javaagent.tooling.config.ResourceProviderPropertiesCustomizerTest$Provider";
"io.opentelemetry.instrumentation.resources.ResourceProviderPropertiesCustomizerTest$Provider";
return Stream.of(
new EnabledTestCase(
"explicitEnabled", true, Collections.emptySet(), Collections.emptySet(), true),
Expand Down Expand Up @@ -119,6 +119,10 @@ Stream<DynamicTest> enabledTestCases() {
Boolean.toString(tc.explicitEnabled));
}

props.put("otel.traces.exporter", "none");
props.put("otel.metrics.exporter", "none");
props.put("otel.logs.exporter", "none");

Attributes attributes =
SdkAutoconfigureAccess.getResourceAttributes(
zeitlinger marked this conversation as resolved.
Show resolved Hide resolved
AutoConfiguredOpenTelemetrySdk.builder()
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
/*
* Copyright The OpenTelemetry Authors
* SPDX-License-Identifier: Apache-2.0
*/

package io.opentelemetry.sdk.autoconfigure;

import io.opentelemetry.api.common.Attributes;

public final class SdkAutoconfigureAccess {
public static Attributes getResourceAttributes(AutoConfiguredOpenTelemetrySdk sdk) {
return sdk.getResource().getAttributes();
}

private SdkAutoconfigureAccess() {}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
io.opentelemetry.instrumentation.resources.ResourceProviderPropertiesCustomizerTest$Provider
1 change: 1 addition & 0 deletions settings.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ include(":javaagent-tooling:javaagent-tooling-java9")
include(":javaagent-internal-logging-application")
include(":javaagent-internal-logging-simple")
include(":javaagent")
include(":sdk-autoconfigure-support")

include(":bom")
include(":bom-alpha")
Expand Down
Loading