Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix RestTemplate for spring boot starter #11034

Closed
wants to merge 4 commits into from
Closed

fix RestTemplate for spring boot starter #11034

wants to merge 4 commits into from

Conversation

zeitlinger
Copy link
Member

I don't know if rest template instrumentation ever worked, because the existing tests were not testing the spring integration (and therefore I deleted the old tests).

@zeitlinger zeitlinger self-assigned this Apr 5, 2024
@zeitlinger zeitlinger requested a review from a team as a code owner April 5, 2024 08:49
@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Apr 5, 2024
@zeitlinger zeitlinger mentioned this pull request Apr 5, 2024
Merged
jeanbisutti
jeanbisutti reviewed Apr 8, 2024
View reviewed changes
Copy link
Member

@jeanbisutti jeanbisutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please create 2 PRs:

  • One for the instrumentation of a RestTemplate bean (test addition, modification of the current bean post processor?)
  • One for the instrumentation of the RestTemplateBuilder

@zeitlinger
Copy link
Member Author

Could you please create 2 PRs:

  • One for the instrumentation of a RestTemplate bean (test addition, modification of the current bean post processor?)
  • One for the instrumentation of the RestTemplateBuilder

Sure 😄

Closed in favor of

#11053
#11054

@zeitlinger zeitlinger closed this Apr 8, 2024
@zeitlinger zeitlinger deleted the spring-boot-rest-template branch April 8, 2024 15:33
@jeanbisutti
Copy link
Member

Could you please create 2 PRs:

  • One for the instrumentation of a RestTemplate bean (test addition, modification of the current bean post processor?)
  • One for the instrumentation of the RestTemplateBuilder

Sure 😄

Closed in favor of

#11053 #11054

Thanks! It's much easier to follow the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanbisutti jeanbisutti jeanbisutti left review comments

Assignees

@zeitlinger zeitlinger

Labels
test native This label can be applied to PRs to trigger them to run native tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zeitlinger @jeanbisutti