Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async operation end strategy for kotlin coroutines flow #11168

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Apr 18, 2024

Hopefully resolves #11035

@laurit laurit requested a review from a team as a code owner April 18, 2024 11:04
Comment on lines -43 to +44
// Use first version with flow support since we have tests for it.
testLibrary("org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.0")
testLibrary("org.jetbrains.kotlinx:kotlinx-coroutines-reactor:1.3.0")
testLibrary("org.jetbrains.kotlinx:kotlinx-coroutines-core:1.0.0")
testLibrary("org.jetbrains.kotlinx:kotlinx-coroutines-reactor:1.0.0")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}
}
withType<Test>().configureEach {
jvmArgs("-Dio.opentelemetry.javaagent.shaded.io.opentelemetry.context.enableStrictContext=false")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥲

@laurit laurit merged commit ac2e8e1 into open-telemetry:main Apr 30, 2024
49 checks passed
@laurit laurit deleted the kotlin-flow-async branch April 30, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracing for Spring Data CoroutineCrudRepository methods is timed incorrectly
3 participants