Convert jdbc library tests from groovy to java #11178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
steverao
reviewed
Apr 19, 2024
...library/src/test/java/io/opentelemetry/instrumentation/jdbc/OpenTelemetryConnectionTest.java
Outdated
Show resolved
Hide resolved
...library/src/test/java/io/opentelemetry/instrumentation/jdbc/OpenTelemetryConnectionTest.java
Outdated
Show resolved
Hide resolved
...rc/test/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcConnectionUrlParserTest.java
Show resolved
Hide resolved
laurit
reviewed
Apr 19, 2024
...library/src/test/java/io/opentelemetry/instrumentation/jdbc/OpenTelemetryConnectionTest.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Apr 19, 2024
...rc/test/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcConnectionUrlParserTest.java
Outdated
Show resolved
Hide resolved
laurit
approved these changes
Apr 22, 2024
|
@jaydeluca looks like you may have missed the |
oops sorry about that, opened a pr to add them back in. Thanks for letting me know |
|
No worries, thanks as always! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7195
I feel terrible asking someone to review
JdbcConnectionUrlParserTest😵💫 , would we prefer to keep this one as groovy for easier readability? Or if someone has any suggestions on a better structure/format/approach for readability let me know and I can try something else.