spring mvc3 - proper span name in case of sec fail (#718) #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
anuraaga,
iNikem,
jkwatson,
trask and
tylerbenson
as code owners
|
|
mateuszrzeszutek
approved these changes
Aug 28, 2020
...io/opentelemetry/instrumentation/auto/springwebmvc/WebApplicationContextInstrumentation.java
Outdated
Show resolved
Hide resolved
...groovy/io/opentelemetry/javaagent/tooling/matcher/AdditionalLibraryIgnoresMatcherTest.groovy
Show resolved
Hide resolved
javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/AgentInstaller.java
Outdated
Show resolved
Hide resolved
...pring-webmvc-3.1/spring-webmvc-3.1-auto/src/test/groovy/test/filter/FilteredAppConfig.groovy
Outdated
Show resolved
Hide resolved
|
@kubawach Can you please rebase this PR and mark resolved comments as such? |
Done. I also managed to work around another Spring Boot 2 change failing one of our tests. |
iNikem
reviewed
Aug 31, 2020
...io/opentelemetry/instrumentation/auto/springwebmvc/WebApplicationContextInstrumentation.java
Outdated
Show resolved
Hide resolved
instrumentation/spring/spring-webmvc-3.1/spring-webmvc-3.1-auto/spring-webmvc-3.1-auto.gradle
Outdated
Show resolved
Hide resolved
instrumentation/spring/spring-webmvc-3.1/spring-webmvc-3.1-auto/src/test/resources/logback.xml
Outdated
Show resolved
Hide resolved
iNikem
approved these changes
Sep 2, 2020
...pring-webmvc-3.1/spring-webmvc-3.1-auto/src/test/groovy/test/filter/FilteredAppConfig.groovy
Outdated
Show resolved
Hide resolved
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switched test instrumentation to use spring boot 2 (de facto standard for many years now)