Add support for redisson instrumentation

[dengliming]

closes #1061

[trask]

Hey @dengliming, this looks great!

Can you implement dbConnectionString(CONNECTION) also?

opentelemetry-java-instrumentation/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/tracer/DatabaseClientTracer.java

Lines 142 to 145 in f738a50

	// TODO make abstract after implementing in all subclasses
	protected String dbConnectionString(CONNECTION connection) {
	return null;
	}

[dengliming]

Hey @dengliming, this looks great!

Can you implement dbConnectionString(CONNECTION) also?

opentelemetry-java-instrumentation/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/tracer/DatabaseClientTracer.java

Lines 142 to 145 in f738a50

	// TODO make abstract after implementing in all subclasses
	protected String dbConnectionString(CONNECTION connection) {
	return null;
	}

Sure. thanks for quick reply : )

[anuraaga]

Thanks, just small and one big point that can probably be saved for later.

[anuraaga]

I don't think we do any truncation in other places, like Lettuce or DB instrumentation. It probably is a good idea but we should do it consistently for all the instrumentation, how about storing everything for now?

[iNikem]

Java SDK already supports truncating too large attributes. So this better be left to them :)

[anuraaga]

Does it make sense to have a more complete async test with callbacks? I notice the return type is RFuture I wonder if our concurrent instrumentation will apply to it.

https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/master/instrumentation/lettuce/lettuce-5.1/src/test/groovy/io/opentelemetry/instrumentation/auto/lettuce/v5_1/LettuceAsyncClientTest.groovy#L327

We can focus on async in another PR though.

[dengliming]

Nothing seems to have changed.

[anuraaga]

Thanks

[anuraaga]

Thanks, this is a good test! I just noticed our async redis tests don't check context propagation, we can look at that separately #1139

[trask]

Thanks @dengliming!