Remove incubating semconv dependency from library instrumentation #11324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
zeitlinger
approved these changes
May 13, 2024
As outlined by @jack-berg libraries should not depend on incubating semconv because there may be breaking changes in that artifact. Imagine a situation where library A depends on one version and B on another version of the incubating semconv. It is possible that no version of the incubating semconv artifact is compatible with both A and B. To avoid this we should not depend on incubating semconv in the libraries that we publish, using it is ok in javaagent code and in tests. The open question is whether we should copy the constants that we need to where we use them, as in this PR, or copy the whole classes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
io.opentelemetry.semconv:opentelemetry-semconv-incubatingdependency from instrumentation api and library instrumentations. Incubating semconv dependency is still used in javaagent instrumentations and tests. Library instrumentations copy the needed keys from incubating semconv classes.