Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract sql operation even when the sanitizer is disabled #11472

Merged
merged 1 commit into from
May 29, 2024

Conversation

laurit
Copy link
Contributor

@laurit laurit commented May 28, 2024

Resolves #11369
Currently even when sanitizer is disabled we still use it to extract the operation in

to use it in the span name. Might as well always use the sanitizer to fill db.operation.

@laurit laurit requested a review from a team as a code owner May 28, 2024 10:46
@laurit laurit merged commit 6c7afce into open-telemetry:main May 29, 2024
53 checks passed
@laurit laurit deleted the sql-sanitizer-operation branch May 29, 2024 06:10
zeitlinger pushed a commit to zeitlinger/opentelemetry-java-instrumentation that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

agent version 2.3, The span attribute of the database span is missing db.operation
3 participants