Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't wrap request/response in Jetty #1156

Merged
merged 3 commits into from
Sep 3, 2020
Merged

Don't wrap request/response in Jetty #1156

merged 3 commits into from
Sep 3, 2020

Conversation

iNikem
Copy link
Contributor

@iNikem iNikem commented Sep 2, 2020

Fixes #1096

anuraaga
anuraaga approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

trask
trask approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it easy to write a test for the problem, so we don't accidentally wrap jetty response in the future?

@iNikem
Copy link
Contributor Author

iNikem commented Sep 3, 2020

I will see what I can do

@iNikem
Copy link
Contributor Author

iNikem commented Sep 3, 2020

@trask Added test and verified that it fails in main branch

@anuraaga anuraaga merged commit ec9c20b into open-telemetry:master Sep 3, 2020
@iNikem iNikem deleted the jetty-counting branch September 3, 2020 07:56
@mateuszrzeszutek mateuszrzeszutek mentioned this pull request Sep 4, 2020
Merged
@trask trask mentioned this pull request Apr 6, 2023
Merged
@siyuniu-ms siyuniu-ms mentioned this pull request Apr 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

@trask trask trask approved these changes

@jkwatson jkwatson Awaiting requested review from jkwatson

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClassCastException for v3_0.CountingHttpServletResponse
3 participants
@iNikem @anuraaga @trask