Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mapping redis (jedis) connection net.peer attributes #1158

Merged
merged 1 commit into from Sep 3, 2020
Merged

mapping redis (jedis) connection net.peer attributes #1158

merged 1 commit into from Sep 3, 2020

Conversation

ghost
Copy link

@ghost ghost commented Sep 2, 2020

Changes to

  • set net.peer.* semantic attributes for jedis instrumentation.- both 1.4 and 3.0
  • utilising existing helper utils
  • making extra effort to resolve address (if hostname, not IP)
  • slight refactor of the utils for method delegation

anuraaga
anuraaga approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@anuraaga anuraaga merged commit f033fd4 into open-telemetry:master Sep 3, 2020
@ghost ghost mentioned this pull request Sep 17, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkwatson jkwatson Awaiting requested review from jkwatson

@trask trask Awaiting requested review from trask

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anuraaga @iNikem @kuba-wu