Properly track causality of kotlin suspend functions #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce new instrumentation to capture kotlin suspended coroutines and track/update Context appropriately. Add high-concurrency test showing the issue and that it is solved.
johnbley
requested review from
anuraaga,
iNikem,
jkwatson,
trask and
tylerbenson
as code owners
iNikem
reviewed
Sep 3, 2020
instrumentation/java-concurrent/kotlin-testing/src/test/kotlin/KotlinCoroutineTests.kt
Outdated
Show resolved
Hide resolved
anuraaga
reviewed
Sep 4, 2020
...in/java/io/opentelemetry/instrumentation/auto/javaconcurrent/KotlinProbeInstrumentation.java
Outdated
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/auto/javaconcurrent/KotlinProbeInstrumentation.java
Outdated
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/auto/javaconcurrent/KotlinProbeInstrumentation.java
Outdated
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/auto/javaconcurrent/KotlinProbeInstrumentation.java
Outdated
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/auto/javaconcurrent/KotlinProbeInstrumentation.java
Outdated
Show resolved
Hide resolved
anuraaga
reviewed
Sep 5, 2020
instrumentation/kotlin-coroutines/kotlin-testing/kotlin-testing.gradle
Outdated
Show resolved
Hide resolved
iNikem
reviewed
Sep 8, 2020
.../java/io/opentelemetry/instrumentation/auto/kotlincoroutines/KotlinProbeInstrumentation.java
Outdated
Show resolved
Hide resolved
.../java/io/opentelemetry/instrumentation/auto/kotlincoroutines/KotlinProbeInstrumentation.java
Outdated
Show resolved
Hide resolved
.../java/io/opentelemetry/instrumentation/auto/kotlincoroutines/KotlinProbeInstrumentation.java
Outdated
Show resolved
Hide resolved
instrumentation/kotlin-coroutines/src/test/kotlin/KotlinCoroutineTests.kt
Show resolved
Hide resolved
Required updating a few kotlin-y things to latest version to properly resolve the jvm variant of their new multiplatform stuff.
iNikem
approved these changes
Sep 9, 2020
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix propagation/causality when kotlin suspend functions are used, by adding instrumentation specific to the kotlin coroutine system.