Support injecting resources into classloader and use it in aws-sdk-2.… #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2 instrumentation.
|
Guess muzzle issue just required a clean :D |
trask
reviewed
Sep 10, 2020
.../io/opentelemetry/instrumentation/auto/javaclassloader/ResourceInjectionInstrumentation.java
Outdated
Show resolved
Hide resolved
added 2 commits
September 14, 2020 11:47
…-instr-java into support-injecting-resources
…RLs directly instead of reading to byte array first.
anuraaga
commented
Sep 14, 2020
...rc/main/java/io/opentelemetry/instrumentation/auto/awssdk/v2_2/AwsClientInstrumentation.java
Show resolved
Hide resolved
iNikem
approved these changes
Sep 14, 2020
|
Probably needs some documentation as well, so that developers of new instrumentation know about this option. |
…-instr-java into support-injecting-resources
…-instr-java into support-injecting-resources
|
@iNikem Hmm - agree that more documentation is always better than less. But we don't have any docs right now for even normal instrumentation I think - I don't want to start documentation with a corner case :) |
trask
reviewed
Sep 15, 2020
javaagent-bootstrap/src/main/java/io/opentelemetry/javaagent/bootstrap/HelperResources.java
Show resolved
Hide resolved
.../io/opentelemetry/instrumentation/auto/javaclassloader/ResourceInjectionInstrumentation.java
Outdated
Show resolved
Hide resolved
trask
approved these changes
Sep 15, 2020
|
Hmm having more flakiness on github actions than before I think. Will go ahead and merge this since 8 unflaked and it's our most representative build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…2 instrumentation.
This adds support for instrumentation to "inject" resource files into classloaders. It does this by intercepting the
getResourcemethod onClassLoaderand have it read from the injected files, which are stored into the bootstrap classloader when applying instrumentation.