Lettuce 5.1 - Remove redis args from span attributes for command such as AUTH #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RashmiRam
requested review from
anuraaga,
iNikem,
jkwatson,
trask and
tylerbenson
as code owners
iNikem
approved these changes
Sep 10, 2020
trask
reviewed
Sep 10, 2020
There was a problem hiding this comment.
Thanks @RashmiRam!
Can you extract the new test out into a separate class, e.g. LettuceSyncClientAuthTest? I think that will be cleaner than spinning up two redis servers in this test, and hopefully we can consolidate into a base class at some point in the future to share similar code across all the Lettuce*ClientTest classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name != "AUTH"check so that args of AUTH command won't be added indb.statementattribute value.LettuceSyncClientTest.groovy