Add instrumentation of SQS. #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sent this as a draft in advance to refer to from spec issue, no need to even start reviewing in detail yet (unless you're interested :) ) |
added 3 commits
September 17, 2020 13:32
anuraaga
requested review from
iNikem,
jkwatson,
trask and
tylerbenson
as code owners
|
Finished it up with my understanding of the current spec. I expect some changes in the spec as working through scenarios in open-telemetry/semantic-conventions#652 but I think this is a pretty good first version. |
anuraaga
commented
Sep 18, 2020
| @@ -21,6 +21,7 @@ muzzle { | |||
| group = "com.amazonaws" | |||
| module = "aws-lambda-java-core" | |||
| versions = "[1.0.0,)" | |||
| extraDependency('com.amazonaws:aws-lambda-java-events:2.2.1') | |||
There was a problem hiding this comment.
I wonder if I should instead of a separate instrumentation module, aws-lambda-sqs-2.2.1 due to this extra, optional dependency. Not quite sure where we want to set boundaries for highly related instrumentation like this case, let me know any thoughts.
There was a problem hiding this comment.
I think it makes sense here to add muzzle requirement on aws-lambda-java-events also, e.g.
pass {
group = "com.amazonaws"
module = "aws-lambda-java-events"
versions = "[2.2.1,)"
extraDependency('com.amazonaws:aws-lambda-java-core:1.0.0')
}
...pentelemetry/instrumentation/auto/awslambda/v1_0/AwsLambdaRequestHandlerInstrumentation.java
Outdated
Show resolved
Hide resolved
iNikem
reviewed
Sep 18, 2020
...pentelemetry/instrumentation/auto/awslambda/v1_0/AwsLambdaRequestHandlerInstrumentation.java
Outdated
Show resolved
Hide resolved
...groovy/io/opentelemetry/instrumentation/awslambda/v1_0/AwsLambdaSqsMessageHandlerTest.groovy
Show resolved
Hide resolved
trask
reviewed
Sep 21, 2020
instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/tracer/BaseTracer.java
Show resolved
Hide resolved
...a/io/opentelemetry/instrumentation/auto/awslambda/v1_0/AbstractAwsLambdaInstrumentation.java
Outdated
Show resolved
Hide resolved
instrumentation/aws-lambda-1.0/library/aws-lambda-1.0-library.gradle
Outdated
Show resolved
Hide resolved
...groovy/io/opentelemetry/instrumentation/awslambda/v1_0/AwsLambdaSqsMessageHandlerTest.groovy
Show resolved
Hide resolved
...pentelemetry/instrumentation/auto/awslambda/v1_0/AwsLambdaRequestHandlerInstrumentation.java
Outdated
Show resolved
Hide resolved
added 2 commits
September 23, 2020 15:52
…-instr-java into sqs-instrumentation
trask
approved these changes
Sep 23, 2020
...a/io/opentelemetry/instrumentation/auto/awslambda/v1_0/AbstractAwsLambdaInstrumentation.java
Outdated
Show resolved
Hide resolved
…etry/instrumentation/auto/awslambda/v1_0/AbstractAwsLambdaInstrumentation.java Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.