Support otlp_span and otlp_metric exporter config names #1253
Conversation
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
pavolloffay
requested review from
anuraaga,
iNikem,
jkwatson,
trask and
tylerbenson
as code owners
pavolloffay
changed the title
| @@ -91,6 +91,7 @@ private static MetricExporterFactory findMetricExporterFactory(String exporterNa | |||
| if (metricExporterFactory | |||
| .getClass() | |||
| .getSimpleName() | |||
| .replace("_", "") | |||
There was a problem hiding this comment.
Hmm - feels a bit magic but I guess it's fine 😃
There was a problem hiding this comment.
yeah, maybe the factories could have a method that returns a name and do the comparison based on that.
There was a problem hiding this comment.
I like the idea of SpanExporterFactory/MetricExporterFactory having a method Set<String> getNames() (Set since e.g. OtlpSpanExporterFactory can be enabled via both otlp and otlp_span)
There was a problem hiding this comment.
I guess this is only applicable to our built-in exporters though, as opposed to someone building their own Exporter and using EXPORTER_JAR, so maybe not. Also, I forget, now that we are Java 8, we can always add interface methods after GA 😁
There was a problem hiding this comment.
Yeah I think my idea before was to have a map of wellknown names, and only use the classname for custom exporters
|
Thanks! |
Signed-off-by: Pavol Loffay ploffay@redhat.com
Resolves #1250
cc) @malafeev