Convert more decorators to tracers #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iNikem
requested review from
anuraaga,
jkwatson,
trask and
tylerbenson
as code owners
trask
approved these changes
Sep 29, 2020
Comment on lines
-95
to
-98
| `ServletContextInstrumentation` instruments `javax.servlet.ServletContext.getRequestDispatcher` and | ||
| `javax.servlet.ServletContext.getNamedDispatcher`. The only job of this instrumentation is to | ||
| preserve the input parameter of those methods and to make that available for `RequestDispatcherInstrumentation` | ||
| described above. The latter uses that name for `dispatcher.target` span attribute. |
| Span span = | ||
| TRACER.spanBuilder(SpringSchedulingDecorator.DECORATE.spanNameOnRun(runnable)).startSpan(); | ||
| SpringSchedulingDecorator.DECORATE.afterStart(span); | ||
| Span span = TRACER.startSpan(TRACER.spanNameOnRun(runnable), Kind.INTERNAL); |
There was a problem hiding this comment.
Should this be Kind.SERVER since it's a "root" span?
There was a problem hiding this comment.
It was INTERNAL before, I haven't changed that. But you have a point... I don' know :)
There was a problem hiding this comment.
I don't think scheduling tasks are really server (no chance of ever being connected to a client). Seems ok to me.
anuraaga
approved these changes
Sep 29, 2020
| Span span = | ||
| TRACER.spanBuilder(SpringSchedulingDecorator.DECORATE.spanNameOnRun(runnable)).startSpan(); | ||
| SpringSchedulingDecorator.DECORATE.afterStart(span); | ||
| Span span = TRACER.startSpan(TRACER.spanNameOnRun(runnable), Kind.INTERNAL); |
There was a problem hiding this comment.
I don't think scheduling tasks are really server (no chance of ever being connected to a client). Seems ok to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.