Allow parenting with the AWS Lambda span itself. #1323
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS Lambda sets an environment variable with a trace header.
For HTTP requests, this is the header for a span which links back to an original HTTP request, for example from API gateway. For X-Ray users, parenting to this will connect back to the client through intermediate spans exported to X-Ray, while showing lambda processing in between. For non-X-ray users, these intermediate spans won't exist and thus the parent must be the client span itself, not the lambda span so the lambda span needs to be ignored.
For SQS requests, this is the header for a span which is a local root for message processing. It never hurts to parent to this, and links will be added which can be used by other tracing backends without problem.
While I considered adding a special configuration for whether to do this parenting or not, it seems that just configuring the propagator works fine so I documented that behavior instead. It means that if a user isn't using X-ray as a backend but wants to use X-Ray trace propagation format for their HTTP requests, it's not supported - I don't think such a user exists in practice though. Let me know if you have any thoughts.