-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run muzzle during PR #1324
Run muzzle during PR #1324
Conversation
|
Do you mind doing a run with cache disabled to measure the time? Some changes, like updating Gradle, will invalidate all cache. That doesn't mean we have to stick with CircleCi but knowing how the worst case does will be helpful. For example, if worst case of CircleCi is 30min and GHA is 4 hours, I don't know what to do. But if the numbers are 30min and 45min for worst case, I won't think any more on the topic :) |
Buildscan claims that we saved 15s due to remote cache. It just needs to compile couple of modules. Probably tests will still be the longest checks |
@anuraaga Tried. Tests are still the longest part. |
Ah - nevermind, why am I not looking at muzzle. Got it |
Here's a muzzle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is muzzle so fast even though it seems like it should be really expensive?
I don't know how
Because it is per module. 2-3 minutes per module is expensive. It's just cheaper that something cheaper (tests) for all modules at once. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every module as a separate job