Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run muzzle during PR #1324

Merged
merged 10 commits into from
Oct 6, 2020
Merged

Run muzzle during PR #1324

merged 10 commits into from
Oct 6, 2020

Conversation

iNikem
Copy link
Contributor

@iNikem iNikem commented Oct 5, 2020

Every module as a separate job

@anuraaga
Copy link
Contributor

anuraaga commented Oct 5, 2020

I don't think our config for muzzle has enabled caching but I see FROM-CACHE in the logs. Do you know how this is happening? Forgot about s3 cache.

@anuraaga
Copy link
Contributor

anuraaga commented Oct 5, 2020

Do you mind doing a run with cache disabled to measure the time? Some changes, like updating Gradle, will invalidate all cache. That doesn't mean we have to stick with CircleCi but knowing how the worst case does will be helpful. For example, if worst case of CircleCi is 30min and GHA is 4 hours, I don't know what to do. But if the numbers are 30min and 45min for worst case, I won't think any more on the topic :)

@iNikem
Copy link
Contributor Author

iNikem commented Oct 5, 2020

Buildscan claims that we saved 15s due to remote cache. It just needs to compile couple of modules. Probably tests will still be the longest checks

@iNikem
Copy link
Contributor Author

iNikem commented Oct 5, 2020

@anuraaga Tried. Tests are still the longest part.

@anuraaga
Copy link
Contributor

anuraaga commented Oct 5, 2020

@iNikem Something magical is going on or I'm not being able to read the logs correctly - isn't ab6b2ca also printing a lot of FROM-CACHE?

@iNikem
Copy link
Contributor Author

iNikem commented Oct 5, 2020

Screenshot 2020-10-05 at 18 47 51

Don't see

@anuraaga
Copy link
Contributor

anuraaga commented Oct 5, 2020

Perhaps it depends on the version. I think your icon on this screenshot makes it clear right? :-)

image

@anuraaga
Copy link
Contributor

anuraaga commented Oct 5, 2020

Ah - nevermind, why am I not looking at muzzle. Got it

@anuraaga
Copy link
Contributor

anuraaga commented Oct 5, 2020

Here's a muzzle with without cache (fairly confident this time but still definitely may be doing something silly :P.

Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is muzzle so fast even though it seems like it should be really expensive?

@iNikem
Copy link
Contributor Author

iNikem commented Oct 5, 2020

I don't know how

Why is muzzle so fast even though it seems like it should be really expensive?

Because it is per module. 2-3 minutes per module is expensive. It's just cheaper that something cheaper (tests) for all modules at once.

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😄

image

@iNikem iNikem merged commit 8510744 into open-telemetry:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants