Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ported JMS 1.x tests to testcontainers #1327

Merged
merged 7 commits into from
Oct 6, 2020
Merged

Ported JMS 1.x tests to testcontainers #1327

merged 7 commits into from
Oct 6, 2020

Conversation

iNikem
Copy link
Contributor

@iNikem iNikem commented Oct 5, 2020

Fixes #1206

@iNikem iNikem mentioned this pull request Oct 5, 2020
Merged
@iNikem
Copy link
Contributor Author

iNikem commented Oct 5, 2020

I have a suspicion that build fails due to AdditionalLibraryIgnoresMatcher and static configs. And I still don't understand why do we need AdditionalLibraryIgnoresMatcher :(

@iNikem
Copy link
Contributor Author

iNikem commented Oct 5, 2020

Yes, CiMate shows nicely that failure is due to AdditionalLibraryIgnoresMatcher. @trask can you remind me, why do we need this matcher and this strange check in our tests?

@tylerbenson
Copy link
Member

The AdditionalLibraryIgnoresMatcher is intended as an optimization for startup to try to bypass a significant amount of classes we know we won't instrument. It's handled a bit differently from other ignores in the tests because if we do happen to instrument something that matches it in a test, then something changed and we need to update the matcher.

trask
trask approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let the testcontainers migration start 🎉

@trask
Copy link
Member

trask commented Oct 6, 2020

Interesting, the muzzle matrix was picked up in this PR even though we didn't merge that change in from master, is that normal?

@iNikem iNikem merged commit aa79224 into open-telemetry:master Oct 6, 2020
@iNikem iNikem deleted the jms-container branch October 6, 2020 07:13
@iNikem iNikem mentioned this pull request Oct 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

@trask trask trask approved these changes

@jkwatson jkwatson Awaiting requested review from jkwatson

@mateuszrzeszutek mateuszrzeszutek Awaiting requested review from mateuszrzeszutek

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test - :instrumentation:jms-1.1:test
4 participants
@iNikem @tylerbenson @trask @anuraaga