Don't mount context in gRPC instrumentation since gRPC automatically … #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
iNikem,
jkwatson,
mateuszrzeszutek,
trask and
tylerbenson
as code owners
|
There's some workarounds for the bootstrap classpath, but it will become simpler after grpc context is gone. |
|
Strange can't repro the test failures locally which is surprising. YOLO workaround seems to have worked though. |
|
Just a note, since I didn't understand this before chatting with @anuraaga, the goal is that piggybacking on the "real" gRPC Context should continue to work even after we migrate to OTel Context because @anuraaga is planning to add interop between OTel Context / gRPC Context interop into the agent at that time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…does it, better.
The client seems to mount the context automatically with no work, and on server we can use
ServerCalls.intercept. This makes sure we don't clobber context modifications that happen downstream from our interceptors./cc @asarkar Thanks for bring this to our attention!