Propagate full context #1350
Merged
Propagate full context #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek and
tylerbenson
as code owners
anuraaga
approved these changes
Oct 9, 2020
| == null) { | ||
| contextStore.get(channel).setConnectionContinuation(span); | ||
| contextStore.get(channel).setConnectionContext(context); |
There was a problem hiding this comment.
Reviewing this made me realize how nervous our propagation patterns make me. Sometimes we propagate the invocation context to remount for an async callback, sometimes the context of the span itself. Makes my head spin 🤯 Don't have a good answer but just food for thought.
iNikem
reviewed
Oct 9, 2020
...io/opentelemetry/instrumentation/auto/netty/v3_8/client/HttpClientRequestTracingHandler.java
Show resolved
Hide resolved
iNikem
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't realize, there were still many places we were only propagating Span as opposed to the full Context