Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muzzle should recognise mismatch on unimplemented abstract methods at runtime #1357

Conversation

mateuszrzeszutek
Copy link
Member

Fixes #1337

It turns out that REFERENCE_CREATION_PACKAGE value at runtime was completely different than at compile time: relocate changed the strings it was not supposed to change - see exclude below:

  // rewrite library instrumentation dependencies
  relocate("io.opentelemetry.instrumentation", "io.opentelemetry.javaagent.shaded.instrumentation") {
    exclude "io.opentelemetry.instrumentation.auto.**"
  }

Thanks @pavolloffay for the repro steps!

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pavolloffay @mateuszrzeszutek!

I created #1364 to add an integration test for this tricky behavior sometime in the future

@pavolloffay
Copy link
Member

thanks @mateuszrzeszutek for looking into this 👍

@trask trask merged commit 59784a5 into open-telemetry:master Oct 9, 2020
vadeg added a commit to vadeg/opentelemetry-java-instrumentation that referenced this pull request Oct 22, 2020
@mateuszrzeszutek mateuszrzeszutek deleted the muzzle-runtime-abstract-methods-fix branch November 18, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Muzzle should recognise mismatch on unimplemented abstract methods at runtime
3 participants