Add server interceptor to end in javaagent because they are run in re… #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
iNikem,
jkwatson,
mateuszrzeszutek,
trask and
tylerbenson
as code owners
anuraaga
commented
Oct 14, 2020
| .intercept(new ServerInterceptor() { | ||
| @Override | ||
| <ReqT, RespT> ServerCall.Listener<ReqT> interceptCall(ServerCall<ReqT, RespT> call, Metadata headers, ServerCallHandler<ReqT, RespT> next) { | ||
| def ctx = Context.current().withValue(key, "meow") | ||
| def oldCtx = ctx.attach() |
There was a problem hiding this comment.
This was wrong in my previous change, naturally just like TracingServerInterceptor, any interceptor that modifies context must use Contexts.interceptCall to make sure it's propagated.
There was a problem hiding this comment.
Incidentally this is much easier when context is mutable :)
iNikem
approved these changes
Oct 14, 2020
mateuszrzeszutek
approved these changes
Oct 14, 2020
trask
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…verse order.
/cc @asarkar This fixes the javaagent which also made the wrong assumption that server interceptors are run in order. But you may be able to get some inspiration from the unit test changes.