Fix HttpURLConnection instrumentation on WebLogic #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoallikmaa
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
trask and
tylerbenson
as code owners
|
|
iNikem
approved these changes
Oct 21, 2020
agoallikmaa
force-pushed
the
weblogic-urlconnection
branch
from
a1a50bc
to
398335a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In WebLogic,
URL.openConnection()returns its own internal implementation ofHttpURLConnection, which does not delegate the methods that have to be instrumented to the JDK superclass.Instrumenting it directly resolves the issue of outgoing requests made with
URL.openConnection()not being detected. It has been manually tested with WLS 12.2.1.4 and 14.1.1.0.