Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couchbase instrumentation should store normalized queries as db.statement #1462

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Couchbase instrumentation should store normalized queries as db.statement #1462

merged 2 commits into from
Oct 27, 2020

Conversation

mateuszrzeszutek
Copy link
Member

Resolves #1444

trask
trask approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mateuszrzeszutek mateuszrzeszutek merged commit d3c3922 into open-telemetry:master Oct 27, 2020
@mateuszrzeszutek mateuszrzeszutek deleted the couchbase-query-normalization branch February 5, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iNikem iNikem iNikem approved these changes

@trask trask trask approved these changes

@anuraaga anuraaga Awaiting requested review from anuraaga

@jkwatson jkwatson Awaiting requested review from jkwatson

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Couchbase instrumentation should store normalized queries as db.statement
3 participants
@mateuszrzeszutek @trask @iNikem