Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrappers for AWS lambda tracing #1471

Merged
merged 3 commits into from Oct 27, 2020
Merged

Wrappers for AWS lambda tracing #1471

merged 3 commits into from Oct 27, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 23, 2020

Resolves #1469

Adds:

  • request streams handler (sibling to already existing request handler)
  • wrappers for handlers, allowing tracing without code modifications
  • tests

@ghost
Copy link
Author

ghost commented Oct 23, 2020

@anuraaga you may want to have a look at this :)

anuraaga
anuraaga reviewed Oct 26, 2020
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this is quite cool

...c/main/java/io/opentelemetry/instrumentation/awslambda/v1_0/TracingRequestStreamHandler.java Show resolved Hide resolved
...c/main/java/io/opentelemetry/instrumentation/awslambda/v1_0/TracingRequestStreamHandler.java Outdated Show resolved Hide resolved
...c/main/java/io/opentelemetry/instrumentation/awslambda/v1_0/TracingRequestStreamWrapper.java Outdated Show resolved Hide resolved
@ghost ghost requested a review from anuraaga October 26, 2020 12:14
@ghost
Copy link
Author

ghost commented Oct 27, 2020

@anuraaga please have a second look :)

anuraaga
anuraaga approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@iNikem iNikem merged commit 3a81c52 into open-telemetry:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iNikem iNikem Awaiting requested review from iNikem

@jkwatson jkwatson Awaiting requested review from jkwatson

@mateuszrzeszutek mateuszrzeszutek Awaiting requested review from mateuszrzeszutek

@trask trask Awaiting requested review from trask

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement AWS lambda tracing wrapper
3 participants
@anuraaga @iNikem @kuba-wu