Simplify JDBC span names #1533
Merged
Simplify JDBC span names #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
trask and
tylerbenson
as code owners
mateuszrzeszutek
changed the title
iNikem
approved these changes
Nov 2, 2020
mateuszrzeszutek
force-pushed
the
simplify-jdbs-span-name
branch
2 times, most recently
from
d69c6a3
to
b4d836f
Compare
johnbley
approved these changes
Nov 9, 2020
...entelemetry/javaagent/instrumentation/api/db/normalizer/SqlStatementInfoExtractorTest.groovy
Show resolved
Hide resolved
trask
approved these changes
Nov 9, 2020
...mentation/jdbc/src/main/java/io/opentelemetry/javaagent/instrumentation/jdbc/JdbcTracer.java
Show resolved
Hide resolved
added 11 commits
November 10, 2020 12:08
* Refactor to state machine * Implement accurate db.sql.table
mateuszrzeszutek
force-pushed
the
simplify-jdbs-span-name
branch
from
9974a9c
to
8e48efa
Compare
trask
reviewed
Nov 10, 2020
...mentation/jdbc/src/main/java/io/opentelemetry/javaagent/instrumentation/jdbc/JdbcTracer.java
Outdated
Show resolved
Hide resolved
…instrumentation/jdbc/JdbcTracer.java Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
|
Nice 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the
<db.operation> <db.name>.<db.sql.table>idea from #1409I think it covers most of the common scenarios (and it's not that complicated).
Spec PR: open-telemetry/opentelemetry-specification#1219