AWS lambda instrumentation - HTTP context propagation #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
trask and
tylerbenson
as code owners
|
@anuraaga please have a look at this - HTTP trace propagation sketch / idea |
anuraaga
reviewed
Nov 2, 2020
...ry/src/main/java/io/opentelemetry/instrumentation/awslambda/v1_0/ApiGatewayProxyRequest.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/opentelemetry/instrumentation/awslambda/v1_0/TracingRequestStreamHandler.java
Outdated
Show resolved
Hide resolved
|
Supporting HTTP propagation is important so generally looks nice, thanks :) |
|
@anuraaga pls have another look :) |
anuraaga
reviewed
Nov 4, 2020
...ry/src/main/java/io/opentelemetry/instrumentation/awslambda/v1_0/ApiGatewayProxyRequest.java
Outdated
Show resolved
Hide resolved
|
@anuraaga added support for XRay propagator and added some tests, pls have another look |
|
Hi @anuraaga please have another look, resolved / responded to your previous comments. Thanks! |
mateuszrzeszutek
approved these changes
Nov 9, 2020
|
Trying to tigger EasyCLA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1535
Sketch of an idea - for streaming handler / wrapper only. If the idea holds, will provide also for instrumentation part and regular handler / wrapper (in applicable cases).