Add support for Reactor Netty's HttpClient #1601
Conversation
iNikem
requested review from
anuraaga,
jkwatson,
mateuszrzeszutek,
trask and
tylerbenson
as code owners
Yes, definitely 😛
Without refactoring |
.../opentelemetry/javaagent/instrumentation/reactor_netty/ReactorHttpClientInstrumentation.java
Outdated
Show resolved
Hide resolved
…ry/javaagent/instrumentation/reactor_netty/ReactorHttpClientInstrumentation.java Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
...elemetry/javaagent/instrumentation/reactor_netty/ReactorHttpClientInstrumentationModule.java
Outdated
Show resolved
Hide resolved
instrumentation/reactor-netty-0.9/src/test/groovy/HttpClientTest.groovy
Outdated
Show resolved
Hide resolved
...opentelemetry/javaagent/instrumentation/reactor_netty/ReactorNettyInstrumentationModule.java
Outdated
Show resolved
Hide resolved
...opentelemetry/javaagent/instrumentation/reactor_netty/ReactorNettyInstrumentationModule.java
Outdated
Show resolved
Hide resolved
| implements BiFunction<Mono<? extends Connection>, Bootstrap, Mono<? extends Connection>> { | ||
| @Override | ||
| public Mono<? extends Connection> apply(Mono<? extends Connection> m, Bootstrap b) { | ||
| return m.subscriberContext(s -> s.put("otel_context", Context.current())); |
There was a problem hiding this comment.
is this attribute name shared with any other instrumentation? if not, maybe name it reactor_netty_otel_context?
There was a problem hiding this comment.
Why, what difference does it make apart having longer key? :)
There was a problem hiding this comment.
when I saw this, the general name gave me the impression that this (reactor) context key was being used to propagate the (otel) context more generally for all reactor instrumentation
There was a problem hiding this comment.
Weeeeellll. That may be totally not a bad idea...
...opentelemetry/javaagent/instrumentation/reactor_netty/ReactorNettyInstrumentationModule.java
Outdated
Show resolved
Hide resolved
Newly added test fails without this instrumentation.
@mateuszrzeszutek should I re-do this as
InstrumentationModule? Can I somehow avoid duplicating all Netty's helper classes?