Add http4k to list of supported libraries #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddenton
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
trask and
tylerbenson
as code owners
|
I've signed the CLA, but it's now showing yet... |
trask
reviewed
Nov 9, 2020
README.md
Outdated
| @@ -236,6 +236,7 @@ Because the automatic instrumentation runs in a different classpath than the ins | |||
| | [gRPC](https://github.com/grpc/grpc-java) | 1.5+ | | |||
| | [Hibernate](https://github.com/hibernate/hibernate-orm) | 3.3+ | | |||
| | [HttpURLConnection](https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/net/HttpURLConnection.html) | Java 7+ | | |||
| | [http4k](https://http4k.org) | 3.270.0+ | | |||
There was a problem hiding this comment.
Hey @daviddenton!
Not sure how best to differentiate between instrumentation provided by this repo and instrumentation provided directly by the library.
I do think it's great to start tracking this.
Maybe:
Suggested change
| | [http4k](https://http4k.org) | 3.270.0+ | | |
| | [http4k<sup>†</sup>](https://http4k.org) | 3.270.0+ | |
and then at the bottom of the table:
<sup>†</sup> OpenTelemetry support built directly into the library
There was a problem hiding this comment.
maybe change link to https://www.http4k.org/guide/modules/opentelemetry/?
and instead of above suggestion:
<sup>†</sup> OpenTelemetry support provided by the library
The CLA check passed so you are all good, not sure why the bot didn't update the commit message. |
|
Both good suggestions - thank you @trask . Have made change - let me know if there's anything else I need to do. 😄 |
trask
approved these changes
Nov 10, 2020
iNikem
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've recently added OTEL support as an optional module to http4k and would love to get it listed here. The module provides simple way of instrumenting http4k apps so that both Metrics and Tracing are available.
You can see how the integration works here. Happy to field questions, and keep up the great work!