Instrument java.servlet.Filter directly #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
instrument-filter-directly
branch
from
cc9cf8c
to
5538fdf
Compare
|
@trask what are your plans for making this real PR? |
trask
force-pushed
the
instrument-filter-directly
branch
from
5538fdf
to
14cd6b4
Compare
trask
commented
Nov 18, 2020
Comment on lines
-25
to
+28
| public class HandlerMappingResourceNameFilter extends OncePerRequestFilter implements Ordered { | ||
| public class HandlerMappingResourceNameFilter implements Filter, Ordered { |
There was a problem hiding this comment.
can't have helper class extend OncePerRequestFilter, because then OncePerRequestFilter won't be instrumented itself
trask
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek and
tylerbenson
as code owners
anuraaga
approved these changes
Nov 18, 2020
|
How does it compare to |
|
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why we instrument
java.servlet.FilterChain.doFilter()instead of the more generaljava.servlet.Filter.doFilter().Let's see if any tests fail with this change 馃槀.
See #1578