Add Bytebuddy agent builder customizer SPI #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
trask and
tylerbenson
as code owners
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
pavolloffay
force-pushed
the
agent-builder-customizer
branch
from
2a161ca
to
11047c0
Compare
|
@pavolloffay can you demonstrate your use-case of actually using this new SPI? |
|
As mentioned in #1534 I want to exclude additional classes. We are building an agent based on OTEL and this SPI gives us control over the ByteBuddy which is an important feature to have. |
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
pavolloffay
changed the title
pavolloffay
changed the title
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
|
👍 do u mind waiting on #1621 and then adding example as part of this PR? |
|
I would prefer to get it merged and do an example separately once the example PR is in. |
trask
approved these changes
Nov 12, 2020
created #1626 and assigned to you 😉 |
iNikem
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1534
Slightly related to #1577 - it will need a different SPI to get the result of
agentBuilder.installOn.