Enable checkstyle for google style guide #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek and
tylerbenson
as code owners
iNikem
reviewed
Nov 16, 2020
...tion-api/src/main/java/io/opentelemetry/instrumentation/api/tracer/DatabaseClientTracer.java
Outdated
Show resolved
Hide resolved
instrumentation/logback/logback-1.0/javaagent/logback-1.0.0-javaagent.gradle
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Nov 16, 2020
|
Going to merge before conflicts start building up. Not a problem to revisit any of the checkstyle rules if you find you don't like something later on. |
mateuszrzeszutek
pushed a commit
to mateuszrzeszutek/opentelemetry-java-instrumentation
that referenced
this pull request
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of #1514
I'll send another PR afterwards to enable
OverloadMethodsDeclarationOrderas it requires moving a few methods around which makes for hard to review diffs.EDIT: also will send separate PR to enable/discuss
ClassTypeParameterNameandMethodTypeParameterName