add b3multi propagator #1647
Merged
add b3multi propagator #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergei Malafeev <sergei@malafeev.org>
malafeev
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
trask and
tylerbenson
as code owners
malafeev
changed the title
malafeev
changed the title
Signed-off-by: Sergei Malafeev <sergei@malafeev.org>
malafeev
changed the title
|
hey @malafeev, can you submit a PR to add
|
iNikem
approved these changes
Nov 17, 2020
trask
approved these changes
Nov 17, 2020
|
@trask do you want to wait for Spec PR to be merged? Or can we merge this right now? |
|
let's give the spec PR 24-hours to see if any concerns are raised, if nothing surfaces then I'm good merging speculatively |
anuraaga
approved these changes
Nov 18, 2020
| @@ -157,7 +157,7 @@ outgoing requests using all the configured propagator formats. | |||
|
|
|||
| | System property | Environment variable | Description | | |||
| |------------------|----------------------|-----------------------------------------------------------------------------------------------------------------| | |||
| | otel.propagators | OTEL_PROPAGATORS | Default is `tracecontext` (W3C). Other supported values are `b3`, `b3single`, `jaeger`, `ottracer`, and `xray`. | | |||
| | otel.propagators | OTEL_PROPAGATORS | Default is `tracecontext` (W3C). Other supported values are `b3`, `b3multi`, `jaeger`, `ottracer`, and `xray`. | | |||
There was a problem hiding this comment.
The behavior of the b3 propagators is a bit confusing so maybe needs some additional docs
`b3` and `b3multi` both extract from the same set of headers, x-b3 multi format and b3 single format. But `b3` injects as b3 single, and `b3multi` injects as x-b3 multi. If you set both `b3` and `b3multi` you can accept and inject all types of b3 headers.
iNikem
pushed a commit
to iNikem/opentelemetry-java-instrumentation
that referenced
this pull request
Nov 18, 2020
* revert support for b3_single and b3 (multi) propagator Signed-off-by: Sergei Malafeev <sergei@malafeev.org> * add b3multi, default for b3 is single Signed-off-by: Sergei Malafeev <sergei@malafeev.org> (cherry picked from commit da9502c)
iNikem
added a commit
that referenced
this pull request
Nov 18, 2020
* Update publish.gradle (#1611) Do not automatically publish to Bintray after upload (cherry picked from commit 7f012c5) * add b3multi propagator (#1647) * revert support for b3_single and b3 (multi) propagator Signed-off-by: Sergei Malafeev <sergei@malafeev.org> * add b3multi, default for b3 is single Signed-off-by: Sergei Malafeev <sergei@malafeev.org> (cherry picked from commit da9502c) Co-authored-by: Sergei Malafeev <sergei@malafeev.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/context/api-propagators.md#b3-requirements: