AWS lambda tracing - http propagation for non-stream handler / wrapper #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
trask and
tylerbenson
as code owners
|
@anuraaga please have a look - hopefully the last one pertaining to context propagation ;) |
anuraaga
reviewed
Nov 17, 2020
...ry/src/main/java/io/opentelemetry/instrumentation/awslambda/v1_0/ApiGatewayProxyRequest.java
Outdated
Show resolved
Hide resolved
...ry/src/main/java/io/opentelemetry/instrumentation/awslambda/v1_0/ApiGatewayProxyRequest.java
Outdated
Show resolved
Hide resolved
...ry/src/main/java/io/opentelemetry/instrumentation/awslambda/v1_0/ParentContextExtractor.java
Outdated
Show resolved
Hide resolved
...ry/src/main/java/io/opentelemetry/instrumentation/awslambda/v1_0/ParentContextExtractor.java
Outdated
Show resolved
Hide resolved
...1.0/library/src/main/java/io/opentelemetry/instrumentation/awslambda/v1_0/WrappedLambda.java
Outdated
Show resolved
Hide resolved
...1.0/library/src/main/java/io/opentelemetry/instrumentation/awslambda/v1_0/WrappedLambda.java
Outdated
Show resolved
Hide resolved
|
@anuraaga please have another look, review comments addressed |
...ry/src/main/java/io/opentelemetry/instrumentation/awslambda/v1_0/ApiGatewayProxyRequest.java
Outdated
Show resolved
Hide resolved
|
@anuraaga @mateuszrzeszutek pls have another look, awaiting review for this one :) |
mateuszrzeszutek
approved these changes
Nov 20, 2020
anuraaga
approved these changes
Nov 20, 2020
|
@anuraaga @mateuszrzeszutek thanks a lot for reviewing, appreciate we made it before the weekend :) |
jkwatson
reviewed
Nov 20, 2020
...src/main/java/io/opentelemetry/instrumentation/awslambda/v1_0/TracingRequestWrapperBase.java
Show resolved
Hide resolved
jkwatson
reviewed
Nov 20, 2020
...1.0/library/src/main/java/io/opentelemetry/instrumentation/awslambda/v1_0/WrappedLambda.java
Outdated
Show resolved
Hide resolved
|
@anuraaga @jkwatson @mateuszrzeszutek all comments addressed, please merge once convenient |
mateuszrzeszutek
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #1649