update SystemMetrics according to spec update #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergei Malafeev <sergei@malafeev.org>
malafeev
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
trask and
tylerbenson
as code owners
Signed-off-by: Sergei Malafeev <sergei@malafeev.org>
|
looks like |
anuraaga
approved these changes
Nov 20, 2020
| .build() | ||
| .setCallback( | ||
| new Callback<LongResult>() { | ||
| @Override | ||
| public void update(LongResult r) { | ||
| GlobalMemory mem = hal.getMemory(); | ||
| r.observe(mem.getTotal() - mem.getAvailable(), Labels.of(TYPE_LABEL_KEY, "used")); | ||
| r.observe(mem.getAvailable(), Labels.of(TYPE_LABEL_KEY, "free")); | ||
| r.observe(mem.getTotal() - mem.getAvailable(), Labels.of("state", "used")); |
There was a problem hiding this comment.
Should we create constants for all the labels?
There was a problem hiding this comment.
updated for label keys
Signed-off-by: Sergei Malafeev <sergei@malafeev.org>
|
test updated |
Signed-off-by: Sergei Malafeev <sergei@malafeev.org>
anuraaga
reviewed
Nov 20, 2020
| @@ -19,7 +19,9 @@ | |||
|
|
|||
| /** System Metrics Utility. */ | |||
| public class SystemMetrics { | |||
| private static final String TYPE_LABEL_KEY = "type"; | |||
| private static final String DEVICE_LABEL_KEY = "device"; | |||
There was a problem hiding this comment.
Shouldn't we do something like private static final Labels STATE_USED = Labels.of("state", "used")? That way we don't have to create a labels object every time we record a value (at least I think that's what's happening right now)
There was a problem hiding this comment.
but it will not work for Labels.of(DEVICE_LABEL_KEY, device, DIRECTION_LABEL_KEY, "transmit")
There was a problem hiding this comment.
updated for state labels
Signed-off-by: Sergei Malafeev <sergei@malafeev.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to spec changes: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/metrics/semantic_conventions/system-metrics.md