Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make muzzle generate helperClassNames() method #1714

Merged

Conversation

mateuszrzeszutek
Copy link
Member

First part of #1374

This PR contains the actual logic behind collecting & ordering helper class names, helperClassNames() methods are left untouched to avoid merge conflicts - I'll remove all those methods in a separate PR.

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️!!

This just bit me (yet again) 😭, I renamed a helper class and forgot to update the helperClassNames(): 2356d5b

I sent a PR to your branch with a couple of potential simplifications. Feel free to add feedback on my PR and we can discuss over there or over here.

@mateuszrzeszutek
Copy link
Member Author

mateuszrzeszutek commented Nov 23, 2020

I sent a PR to your branch with a couple of potential simplifications. Feel free to add feedback on my PR and we can discuss over there or over here.

Nice! I love how it simplified the dependency cycle stuff.

I've added some minor stuff over that: one more unit test, removed getClassName() method that was not necessary.

@mateuszrzeszutek mateuszrzeszutek mentioned this pull request Nov 23, 2020
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent a small commit directly to your branch to clarify my understanding of what the tests are testing, let me know if looks good

@mateuszrzeszutek
Copy link
Member Author

I sent a small commit directly to your branch to clarify my understanding of what the tests are testing, let me know if looks good

👍 Thanks!

I've added one more assertion for the enum class:

    assertThatContainsInOrder helperClasses, [
      OtherTestHelperClasses.TestEnum.name,
      OtherTestHelperClasses.TestEnum.name + '$1',
    ]

@trask
Copy link
Member

trask commented Nov 24, 2020

I've added one more assertion for the enum class

oh yes! I didn't notice that extends relationship 👍

@trask trask merged commit 13c405c into open-telemetry:master Nov 24, 2020
@trask
Copy link
Member

trask commented Nov 24, 2020

🎉🎉🎉

@mateuszrzeszutek mateuszrzeszutek deleted the generate-helperClassNames branch February 5, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants