-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make muzzle generate helperClassNames() method #1714
Make muzzle generate helperClassNames() method #1714
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️!!
This just bit me (yet again) 😭, I renamed a helper class and forgot to update the helperClassNames()
: 2356d5b
I sent a PR to your branch with a couple of potential simplifications. Feel free to add feedback on my PR and we can discuss over there or over here.
Nice! I love how it simplified the dependency cycle stuff. I've added some minor stuff over that: one more unit test, removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I sent a small commit directly to your branch to clarify my understanding of what the tests are testing, let me know if looks good
23c3b4a
to
aee6018
Compare
👍 Thanks! I've added one more assertion for the enum class: assertThatContainsInOrder helperClasses, [
OtherTestHelperClasses.TestEnum.name,
OtherTestHelperClasses.TestEnum.name + '$1',
] |
oh yes! I didn't notice that extends relationship 👍 |
🎉🎉🎉 |
First part of #1374
This PR contains the actual logic behind collecting & ordering helper class names,
helperClassNames()
methods are left untouched to avoid merge conflicts - I'll remove all those methods in a separate PR.