Pass around context more instead of span (HttpServerTracer) #1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek and
tylerbenson
as code owners
iNikem
reviewed
Dec 1, 2020
.../src/main/java/io/opentelemetry/instrumentation/armeria/v1_0/server/ArmeriaServerTracer.java
Outdated
Show resolved
Hide resolved
...entation-api/src/main/java/io/opentelemetry/instrumentation/api/tracer/HttpServerTracer.java
Show resolved
Hide resolved
anuraaga
approved these changes
Dec 1, 2020
mateuszrzeszutek
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to #1525
CONTEXT_SERVER_SPAN_KEYinstartSpan()instead ofstartScope()HttpServerTracer.startScope()doesn't do anything after above change, so removedContexttoend()andendExceptionally(), since now don't typically have Span reference handy to pass in