Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix liberty docker images #1853

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Fix liberty docker images #1853

merged 1 commit into from
Dec 9, 2020

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Dec 8, 2020

  • enable javaee-8.0 feature, without any features enabled nothing works as servlet support is also a feature
  • liberty base image symlinks config directory, can't copy it because it copies the target directory instead of symlink

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 8, 2020 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@laurit laurit closed this Dec 8, 2020
@laurit laurit reopened this Dec 8, 2020
@iNikem
Copy link
Contributor

iNikem commented Dec 9, 2020

  • liberty base image symlinks config directory, can't copy it because it copies the target directory instead of symlink

Why is this a bad thing?

@laurit
Copy link
Contributor Author

laurit commented Dec 9, 2020

  • liberty base image symlinks config directory, can't copy it because it copies the target directory instead of symlink

Why is this a bad thing?

Because server.xml needs to end up in /opt/ol/wlp/usr/servers/defaultServer/server.xml if config is a plain directory then it will end up in /config/server.xml which is unrelated to server and won't do anything. The same thing applies to app.war.

@iNikem iNikem merged commit f062ee4 into open-telemetry:master Dec 9, 2020
bhautikpip pushed a commit to bhautikpip/opentelemetry-java-instrumentation that referenced this pull request Dec 18, 2020
@laurit @bhautikpip
fix liberty docker images (open-telemetry#1853)
5058ab4
@laurit laurit deleted the fix-liberty-docker-image branch December 22, 2020 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iNikem iNikem iNikem approved these changes

@anuraaga anuraaga Awaiting requested review from anuraaga

@jkwatson jkwatson Awaiting requested review from jkwatson

@mateuszrzeszutek mateuszrzeszutek Awaiting requested review from mateuszrzeszutek

@trask trask Awaiting requested review from trask

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@laurit @iNikem