Add exporter factory for JaegerThriftSpanExporter #1868
Conversation
breedx-splk
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
trask and
tylerbenson
as code owners
|
I suspect you'll need okhttp & jackson to be shaded in there, but I'm not sure. |
|
What's the best way to find that out? |
|
hey @breedx-splk! jaeger and otlp just need some grpc-netty artifact, seems we picked grpc-netty-shaded, but that's not related to the agent shading. the exporters live in the AgentClassLoader, where things aren't shaded, except for references to otel API, SLF4J and j.u.l. which need to talk to our shaded versions of those libraries that are in the bootstrap class loader. does the collector have a jaeger-thrift pipeline, so we can add a smoke test similar to JaegerExporterSmokeTest? also, can you submit a separate PR updating the README.md with the new exporter details? we'll merge the doc PR separately when the next release goes live |
smoke-tests/src/test/groovy/io/opentelemetry/smoketest/JaegerThriftExporterSmokeTest.groovy
Show resolved
Hide resolved
* add exporter factory for JaegerThriftSpanExporter * add smoke test
This resolves #1609
I just followed the existing patterns/conventions.
I wasn't entirely sure why the jaeger grpc exporter needed the shaded netty, so I didn't bring it over. Does this exporter need something similarly shaded?