Muzzle should add SPI classes defined in helperResourceNames as references #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
trask and
tylerbenson
as code owners
anuraaga
approved these changes
Dec 16, 2020
| "io.opentelemetry.instrumentation.awssdk.v2_2.TracingExecutionInterceptor", | ||
| "io.opentelemetry.extension.trace.propagation.AwsXRayPropagator" | ||
| }; | ||
| return new String[] {"io.opentelemetry.extension.trace.propagation.AwsXRayPropagator"}; |
There was a problem hiding this comment.
Thanks a lot for the change!!! Just checking, will muzzle task fail if this class isn't included now?
There was a problem hiding this comment.
Yes, it will:
FAILED MUZZLE VALIDATION: io.opentelemetry.javaagent.instrumentation.awssdk.v2_2.AwsSdkInstrumentationModule mismatches:
-- io.opentelemetry.instrumentation.awssdk.v2_2.AwsSdkHttpClientTracer:39 Missing class io.opentelemetry.extension.trace.propagation.AwsXRayPropagator
| } | ||
|
|
||
| List<String> spiImplementations = new ArrayList<>(); | ||
| try (InputStream stream = getResourceStream(resource)) { |
There was a problem hiding this comment.
Is it possible to use Files.lines or Files.readAllLines?
There was a problem hiding this comment.
I wanted to use one of those but they all accept Path - and we pretty much have to use InputStream here because of connection.setUseCaches(false)
trask
approved these changes
Dec 16, 2020
bhautikpip
pushed a commit
to bhautikpip/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1887